-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor add/delete API as an enabler for tiered index #319
Conversation
Codecov ReportBase: 96.19% // Head: 96.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
==========================================
+ Coverage 96.19% 96.21% +0.01%
==========================================
Files 63 63
Lines 3526 3536 +10
==========================================
+ Hits 3392 3402 +10
Misses 134 134
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…the external interface.
…ppend vector" methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change function comments from override
to overwrite
…from label lookup.
override_allowed
flag toaddVector
interface, so we can enforce that the internal HNSW index within the tiered index will not be able to override existing vectors (rather than creating a delete job in advance).indexCapacity()
andresize()
to index interface and adjust the existing indexes accordingly. Call resize before we add new vectors externally invec_sim.cpp