pybind: replaced input type to bytearray - MOD-4597 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added test for fp32, fp64 and L2, cosine
Codecov ReportBase: 96.58% // Head: 96.58% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 61 61
Lines 3482 3482
=======================================
Hits 3363 3363
Misses 119 119 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
meiravgri
changed the title
…to pybind_get_input_as_bytearray
GuyAv46
reviewed
Dec 18, 2022
GuyAv46
reviewed
Dec 19, 2022
GuyAv46
reviewed
Dec 19, 2022
GuyAv46
reviewed
Dec 19, 2022
DvirDukhan
reviewed
Dec 20, 2022
src/python_bindings/bindings.cpp
Outdated
| @@ -69,24 +69,33 @@ class PyBatchIterator { | |||
| void reset() { VecSimBatchIterator_Reset(batchIterator.get()); } | |||
| virtual ~PyBatchIterator() {} | |||
| }; | |||
| #include <pybind11/embed.h> | |||
There was a problem hiding this comment.
move include up the file?
There was a problem hiding this comment.
forgot to remove it
DvirDukhan
approved these changes
Dec 21, 2022
alonre24
pushed a commit
that referenced
this pull request
Apr 4, 2023
* replaced input type to bytearray * added a module to convert numpy to bytearay * moved mybytearray to python bindings lib
alonre24
pushed a commit
that referenced
this pull request
Apr 4, 2023
* replaced input type to bytearray * added a module to convert numpy to bytearay * moved mybytearray to python bindings lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
The index function in bindings.cpp convert the py::object into a pointer directly instead of into an array
Which issues this PR fixes
Main objects this PR modified
1.bindings.cpp
2. test_hnswlib.py
3. test_bruteforce.py
4. bm_datasets.py
Mark if applicable