Skip to content

Conversation

filipecosta90
Copy link
Collaborator

@filipecosta90 filipecosta90 commented Jul 24, 2020

fixes #77
This PR enable Go Modules and it's backwards compatible with old go versions.

@filipecosta90 filipecosta90 requested a review from gkorland July 24, 2020 17:27
gkorland
gkorland previously approved these changes Jul 26, 2020
@filipecosta90 filipecosta90 changed the title Enable Go Modules Enable Go Modules, Fix tests for 2.0+ version Jul 26, 2020
@filipecosta90 filipecosta90 requested a review from gkorland July 26, 2020 13:23
@codecov
Copy link

codecov bot commented Jul 26, 2020

Codecov Report

Merging #78 into master will increase coverage by 0.99%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   75.14%   76.14%   +0.99%     
==========================================
  Files          12       12              
  Lines        1203     1203              
==========================================
+ Hits          904      916      +12     
+ Misses        236      227       -9     
+ Partials       63       60       -3     
Impacted Files Coverage Δ
redisearch/client.go 80.15% <ø> (ø)
redisearch/query.go 85.40% <100.00%> (+6.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 236fe93...47a62e9. Read the comment docs.

@filipecosta90 filipecosta90 merged commit a48d16f into master Jul 28, 2020
@filipecosta90 filipecosta90 deleted the go.mod branch July 28, 2020 08:25
@filipecosta90 filipecosta90 restored the go.mod branch January 13, 2021 09:47
@filipecosta90 filipecosta90 deleted the go.mod branch January 13, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rely on Go Modules to ensure package dependencies and replicable builds

2 participants