support for [TEMPORARY {seconds}] on FT.CREATE #70
Conversation
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 75.04% 75.27% +0.22%
==========================================
Files 12 12
Lines 1182 1197 +15
==========================================
+ Hits 887 901 +14
- Misses 231 233 +2
+ Partials 64 63 -1
Continue to review full report at Codecov.
|
| // To enable the temporary index creation, use SetTemporaryPeriod(). This method should be preferably used for disabling the flag | ||
| func (options *Options) SetTemporary(temporary bool) *Options { | ||
| options.Temporary = temporary | ||
| return options |
There was a problem hiding this comment.
Not sure someone will create a temporary object and then regret ... but it's ok to have this api I guess..
There was a problem hiding this comment.
I believe it makes sense if you want to reuse options across several creations. WDYT?
| @@ -0,0 +1,26 @@ | |||
| # Go parameters | |||
| GOCMD=go | |||
There was a problem hiding this comment.
Is it common on go project to have a Makefile?
There was a problem hiding this comment.
I knew someone would pick on the GOCMD =)
regarding the makefile I believe it helps both for developing, manual testing and CI. cc @rafie
cc @gkorland