Skip to content

Conversation

@filipecosta90
Copy link
Collaborator

@filipecosta90 filipecosta90 commented Mar 30, 2020

  • Increases coverage on document and spellcheck. We should now be at ~70%.
  • extended Paging tests to make sure we're OK on serialization.
  • reduces complexity of FT.AGGREGATE response parsing.
  • extends FT.AGGREGATE tests to make sure we're correctly processing replies.

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #48 into master will increase coverage by 4.57%.
The diff coverage is 79.31%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #48      +/-   ##
=========================================
+ Coverage   63.53%   68.1%   +4.57%     
=========================================
  Files          12      12              
  Lines         905     925      +20     
=========================================
+ Hits          575     630      +55     
+ Misses        272     239      -33     
+ Partials       58      56       -2
Impacted Files Coverage Δ
redisearch/client.go 67.45% <50%> (+0.2%) ⬆️
redisearch/aggregate.go 69.69% <81.25%> (+0.82%) ⬆️
redisearch/spellcheck.go 86.84% <81.81%> (+38.35%) ⬆️
redisearch/document.go 72.72% <0%> (+36.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e440655...5cfa76b. Read the comment docs.

@filipecosta90 filipecosta90 changed the title Extend.coverage Extend coverage Mar 31, 2020
@filipecosta90
Copy link
Collaborator Author

@gkorland can you review this one. No added feature, just increased coverage :)

@gkorland gkorland requested review from itamarhaber and removed request for gkorland March 31, 2020 07:38
@lgtm-com
Copy link

lgtm-com bot commented Apr 1, 2020

This pull request introduces 1 alert when merging 5cfa76b into e440655 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

Copy link
Contributor

@itamarhaber itamarhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkorland gkorland merged commit 522e62a into master Apr 2, 2020
@gkorland gkorland deleted the extend.coverage branch April 2, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants