Skip to content

Conversation

@filipecosta90
Copy link
Collaborator

@filipecosta90 filipecosta90 commented Dec 17, 2019

  • [add] support for FT.GET and FT.MGET
  • [add] support for FT.SUGLEN and FT.SUGDEL
  • [add] added default options for FT.SUGGET.
  • [add] add support for FT.DICTADD FT.DICTDEL and FT.DICTDUMP
  • [add] added support for FT.ALIASADD, FT.ALIASUPDATE, FT.ALIASDEL
  • [add] Increased coverage

@filipecosta90 filipecosta90 changed the title . Included default options for … support for FT.SUGLEN and FT.SUGDEL and refactor Dec 17, 2019
@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #36 into master will increase coverage by 4.10%.
The diff coverage is 68.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   68.10%   72.21%   +4.10%     
==========================================
  Files          12       12              
  Lines         925     1040     +115     
==========================================
+ Hits          630      751     +121     
+ Misses        239      231       -8     
- Partials       56       58       +2     
Impacted Files Coverage Δ
redisearch/pool.go 85.71% <0.00%> (+54.67%) ⬆️
redisearch/schema.go 75.55% <ø> (ø)
redisearch/suggest.go 0.00% <ø> (ø)
redisearch/autocomplete.go 55.67% <44.44%> (+1.50%) ⬆️
redisearch/query.go 74.87% <62.24%> (-11.36%) ⬇️
redisearch/document.go 72.58% <72.41%> (-0.15%) ⬇️
redisearch/client.go 78.47% <90.58%> (+11.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 522e62a...82d2f33. Read the comment docs.

@filipecosta90 filipecosta90 changed the title support for FT.SUGLEN and FT.SUGDEL and refactor support for FT.SUGLEN, FT.SUGDEL, FT.ALIASADD, FT.ALIASUPDATE, FT.ALIASDEL, FT.DICTADD, FT.DICTDEL, FT.DICTDUMP Mar 31, 2020
@filipecosta90 filipecosta90 changed the title support for FT.SUGLEN, FT.SUGDEL, FT.ALIASADD, FT.ALIASUPDATE, FT.ALIASDEL, FT.DICTADD, FT.DICTDEL, FT.DICTDUMP support for FT.GET, FT.MGET, FT.SUGLEN, FT.SUGDEL, FT.ALIASADD, FT.ALIASUPDATE, FT.ALIASDEL, FT.DICTADD, FT.DICTDEL, FT.DICTDUMP Mar 31, 2020
@filipecosta90
Copy link
Collaborator Author

@mnunberg and @MeirShpilraien can you guys revise this one :) it extends the client support commands

@filipecosta90
Copy link
Collaborator Author

@itamarhaber also added the inline docs for IndexingOptions and moved IndexingOptions from query.go to document.go since they represent the options for indexing a single document

Copy link
Contributor

@itamarhaber itamarhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants