Skip to content

Support LOAD * in FT.AGGREGATE #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2022
Merged

Support LOAD * in FT.AGGREGATE #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
194be7d
Support LOAD * in FT.AGGREGATE
Apr 5, 2022
c153f9f
document
Apr 5, 2022
a22baaf
add point
Apr 5, 2022
184928b
Merge branch 'master' into Aggregate_LOADALL
Avital-Fine Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion redisearch/aggregate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,9 +201,13 @@ func (a *AggregateQuery) Limit(offset int, num int) *AggregateQuery {
return a
}

//Load document fields from the document HASH objects (if they are not in the sortables)
//Load document fields from the document HASH objects (if they are not in the sortables).
//Empty array will load all properties.
func (a *AggregateQuery) Load(Properties []string) *AggregateQuery {
nproperties := len(Properties)
if nproperties == 0 {
a.AggregatePlan = a.AggregatePlan.Add("LOAD", "*")
}
if nproperties > 0 {
a.AggregatePlan = a.AggregatePlan.Add("LOAD", nproperties)
for _, property := range Properties {
Expand Down
4 changes: 2 additions & 2 deletions redisearch/aggregate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,10 +616,10 @@ func TestAggregateQuery_Load(t *testing.T) {
args{[]string{"field1", "field2", "field3", "field4"}},
redis.Args{"*", "LOAD", 4, "@field1", "@field2", "@field3", "@field4"},
},
{"TestAggregateQuery_Load_Empty",
{"TestAggregateQuery_Load_All",
fields{nil, redis.Args{}, nil, 0, false, false, false, nil},
args{[]string{}},
redis.Args{"*"},
redis.Args{"*", "LOAD", "*"},
},
}
for _, tt := range tests {
Expand Down