Skip to content

fix #143 FILTER should not have white space from the EXCLUDE ( #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 5, 2022
Merged

fix #143 FILTER should not have white space from the EXCLUDE ( #145

merged 5 commits into from
Apr 5, 2022

Conversation

gkorland
Copy link
Contributor

@gkorland gkorland commented Apr 4, 2022

No description provided.

@gkorland gkorland changed the title fix #143 FILTER should not white space from the EXCLUDE ( fix #143 FILTER should not have white space from the EXCLUDE ( Apr 4, 2022
@gkorland gkorland linked an issue Apr 4, 2022 that may be closed by this pull request
When appendNumArgs has exclude flag, it should append "(" and num together #143
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Apr 4, 2022 •
edited
Loading

Codecov Report

Merging #145 (464d87d) into master (7a5af81) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   74.62%   74.77%   +0.14%     
==========================================
  Files          13       13              
  Lines        1344     1344              
==========================================
+ Hits         1003     1005       +2     
+ Misses        286      285       -1     
+ Partials       55       54       -1
Impacted Files Coverage Δ
redisearch/query.go 86.03% <100.00%> (ø)
redisearch/client.go 69.90% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a5af81...464d87d. Read the comment docs.

@xjplke
Copy link
Contributor

xjplke commented Apr 4, 2022

It's great

@gkorland gkorland requested a review from chayim April 5, 2022 05:30
@chayim chayim merged commit 23c6554 into master Apr 5, 2022
@chayim chayim deleted the gkorland-exclude-filter branch April 5, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chayim chayim chayim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When appendNumArgs has exclude flag, it should append "(" and num together

3 participants

@gkorland @xjplke @chayim