-
Notifications
You must be signed in to change notification settings - Fork 69
support NOHL and SKIPINITIALSCAN tags on FT.CREATE #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7980271
to
e8c5bd4
Compare
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
==========================================
+ Coverage 77.67% 77.99% +0.31%
==========================================
Files 13 13
Lines 1326 1336 +10
==========================================
+ Hits 1030 1042 +12
+ Misses 237 236 -1
+ Partials 59 58 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AvitalFineRedis can we also add a flow test / or even an example to test this not only from the perspective of the client (with the unit tests) but also to confirm the create options are properly interpreted by research (with the flow tests)?
b2d7b24
to
e4d70ec
Compare
…earch v1.6 compatible testing
…docs to be indexed before querying
Kudos, SonarCloud Quality Gate passed!
|
flush(c) | ||
schema := NewSchema(Options{NoOffsetVectors: true}).AddField(NewTextField("body")) | ||
|
||
c.CreateIndex(schema) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
errcheck: Error return value of c.CreateIndex
is not checked
(at-me in a reply with help
or ignore
)
No description provided.