Skip to content

Conversation

AvitalFineRedis
Copy link
Contributor

No description provided.

@AvitalFineRedis AvitalFineRedis changed the title NOHL and SKIPINITIALSCAN support NOHL and SKIPINITIALSCAN tags on FT.CREATE Aug 5, 2021
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #125 (10371bc) into master (bd1fa60) will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   77.67%   77.99%   +0.31%     
==========================================
  Files          13       13              
  Lines        1326     1336      +10     
==========================================
+ Hits         1030     1042      +12     
+ Misses        237      236       -1     
+ Partials       59       58       -1     
Impacted Files Coverage Δ
redisearch/schema.go 87.50% <100.00%> (+0.79%) ⬆️
redisearch/client.go 82.12% <0.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd1fa60...10371bc. Read the comment docs.

@AvitalFineRedis AvitalFineRedis linked an issue Aug 5, 2021 that may be closed by this pull request
Copy link
Collaborator

@filipecosta90 filipecosta90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvitalFineRedis can we also add a flow test / or even an example to test this not only from the perspective of the client (with the unit tests) but also to confirm the create options are properly interpreted by research (with the flow tests)?

@AvitalFineRedis AvitalFineRedis force-pushed the NOHL_and_SKIPINITIALSCAN branch from b2d7b24 to e4d70ec Compare August 8, 2021 08:12
filipecosta90
filipecosta90 previously approved these changes Aug 9, 2021
@filipecosta90 filipecosta90 self-requested a review August 10, 2021 09:21
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AvitalFineRedis AvitalFineRedis merged commit 90b2295 into master Aug 10, 2021
@AvitalFineRedis AvitalFineRedis deleted the NOHL_and_SKIPINITIALSCAN branch August 10, 2021 09:46
flush(c)
schema := NewSchema(Options{NoOffsetVectors: true}).AddField(NewTextField("body"))

c.CreateIndex(schema)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errcheck: Error return value of c.CreateIndex is not checked
(at-me in a reply with help or ignore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support NOHL and SKIPINITIALSCAN tags in FT.CREATE

2 participants