Skip to content

[FEATURE] Add LOAD ALL for FT.AGGREGATE #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2021
Merged

[FEATURE] Add LOAD ALL for FT.AGGREGATE #2243

merged 2 commits into from
Sep 19, 2021

Conversation

@ashtul
Copy link
Contributor

@ashtul ashtul commented Sep 14, 2021 •
edited
Loading

fixes #1816

@ashtul ashtul merged commit 12faf75 into master Sep 19, 2021
@ashtul ashtul deleted the Ariel_load_all branch September 19, 2021 16:00
@ashtul ashtul mentioned this pull request Sep 22, 2021
Closed
rafie pushed a commit that referenced this pull request Sep 26, 2021
@rafie
[FEATURE] Add LOAD ALL for FT.AGGREGATE (#2243)
f6eb662 
(cherry picked from commit 12faf75)
rafie added a commit that referenced this pull request Sep 26, 2021
@rafie
Disable LOAD ALL (#2243)
0e46469
@gkorland
Copy link
Contributor

@ashtul missing the docs update.
@emmanuelkeller I think we should use * and not the ALL keyword. Let's try to avoid adding new keywords.

@ashtul
Copy link
Contributor Author

ashtul commented Oct 4, 2021 •
edited
Loading

@gkorland The ALL keyword is local to SORTBY, not everywhere the syntax.
* is better.

This was referenced Nov 1, 2021
Open
Closed
ashtul pushed a commit that referenced this pull request Nov 4, 2021
@ashtul
[FEATURE] Add LOAD ALL for FT.AGGREGATE (#2243)
a1d1273 
(cherry picked from commit 12faf75)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MeirShpilraien MeirShpilraien Awaiting requested review from MeirShpilraien

@emmanuelkeller emmanuelkeller Awaiting requested review from emmanuelkeller

@oshadmi oshadmi Awaiting requested review from oshadmi

1 more reviewer

@rafie rafie rafie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c:feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Load all keys of hash in FT.AGGREGATE query.

4 participants

@ashtul @gkorland @rafie