Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SystemsTable): Fix resetting to default filters #1985

Merged
merged 2 commits into from
Sep 25, 2023
Merged

fix(SystemsTable): Fix resetting to default filters #1985

merged 2 commits into from
Sep 25, 2023

Conversation

bastilian
Copy link
Member

This fixes resetting the filters to the default filters on the Systems page.

  1. Go to Vulnerability app, Systems page
  2. Remove default "Systems with Vulnerability analysis enabled: Enabled systems" filter
  3. Click "Reset filters"
  4. The default filter should be enabled again

@bastilian bastilian requested a review from a team as a code owner September 22, 2023 08:52
@jira-linking
Copy link

jira-linking bot commented Sep 22, 2023 •
edited
Loading

Commits missing Jira IDs:
eb9c80e
dfee2c7

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023 •
edited
Loading

Codecov Report

Patch has no changes to coverable lines.

❗ Current head eb9c80e differs from pull request most recent head 210e50e. Consider uploading reports for the commit 210e50e to get more accurate results

Files Changed Coverage
src/Helpers/TableToolbarHelper.js ø

📢 Thoughts on this report? Let us know!.

adonispuente
adonispuente reviewed Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@adonispuente adonispuente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When testing this PR, I've found an issue with the reset button.
If you add OS filters, and then select 'reset filters' button, the filters/chips are no longer removed

@bastilian bastilian changed the title fix(SystemsTable): Remove redundant removeFilter call fix(SystemsTable): Fix resetting to default filters Sep 25, 2023
@bastilian
Copy link
Member Author

@adonispuente Thank you for taking a look and testing! The resetting should now work properly in any case! Would you mind taking another looksie?

adonispuente
adonispuente approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@adonispuente adonispuente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as intended, LGTM!

@bastilian bastilian merged commit 6201326 into RedHatInsights:master Sep 25, 2023
4 checks passed
leSamo pushed a commit that referenced this pull request Sep 25, 2023
@semantic-release-bot
chore(release): 1.104.4
fd52e0c 
## [1.104.4](v1.104.3...v1.104.4) (2023-09-25)

### Bug Fixes

* **SystemsTable:** Fix resetting to default filters ([#1985](#1985)) ([6201326](6201326))
Jason-RH pushed a commit to RedHatInsights/vulnerability-ui-build that referenced this pull request Sep 25, 2023
chore(release): 1.104.4
c515a1a 
## [1.104.4](RedHatInsights/vulnerability-ui@v1.104.3...v1.104.4) (2023-09-25)

### Bug Fixes

* **SystemsTable:** Fix resetting to default filters ([#1985](RedHatInsights/vulnerability-ui#1985)) ([6201326](RedHatInsights/vulnerability-ui@6201326))
LiorKGOW pushed a commit to LiorKGOW/vulnerability-ui that referenced this pull request Jan 8, 2024
@gkarat
fix(ESSNTL-4667): Disable global filter at groups views (RedHatInsigh…
cd00a74 
…ts#1985)

Fixes https://issues.redhat.com/browse/ESSNTL-4667.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adonispuente adonispuente adonispuente approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastilian @codecov-commenter @adonispuente