fix(SystemsTable): Remove redundant removeFilter call

RedHatInsights · Sep 22, 2023 · eb9c80e · eb9c80e
1 parent 0340bad
commit eb9c80e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/Helpers/TableToolbarHelper.js b/src/Helpers/TableToolbarHelper.js
@@ -102,7 +102,6 @@ export const buildActiveFilters = (currentFilters, filterRuleValues = []) => {
 
 export const removeFilters = (chips, apply, reset = false, defaultFilters = {}) => {
     if (reset) {
-        removeFilters(chips, apply);
         apply({ ...defaultFilters, page: 1 });
         return;
     }

diff --git a/src/Helpers/TableToolbarHelper.test.js b/src/Helpers/TableToolbarHelper.test.js
@@ -25,6 +25,10 @@ const mockGeneralChip = {
 const mockApply = jest.fn();
 
 describe('TableToolbarHelper', () => {
+    afterEach(() => {
+      jest.clearAllMocks();
+    });
+
     it('Should handleChangePage apply with provided page', () => {
         const testPage = 1;
         const testApply = jest.fn();
@@ -149,6 +153,12 @@ describe('TableToolbarHelper', () => {
         expect(mockApply).toHaveBeenCalledWith({ rule_presence: undefined, rule: '', page: 1 });
     });
 
+    it('Should reset to default filters when given and reset is ture', () => {
+        removeFilters([mockGeneralChip], mockApply, true, { rule_presence: "true" });
+        expect(mockApply).toHaveBeenCalledTimes(1);
+        expect(mockApply).toHaveBeenCalledWith({ rule_presence: 'true', page: 1 });
+    });
+
     it('Should remove search filters and multi value filters with only one value safely', () => {
         const mockSingleValueChips = [
             {