Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TopCrop option to ScaleType #372

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Add TopCrop option to ScaleType #372

merged 1 commit into from
Dec 10, 2021

Conversation

AliAsadi
Copy link
Contributor

Add the ability to make TopCrop in ScaleType.

TopCrop will work the same as CenterCrop in full mode when the CameraView hight = "match_parent"

But when the user decided to show half of the camera for example if hight = "300dp",
the CenterCrop will show the center part of the camera while the TopCrop will show the top part.

@AliAsadi AliAsadi requested a review from Diolor January 19, 2020 12:57
@dmitry-zaitsev dmitry-zaitsev merged commit 9454f3e into RedApparat:master Dec 10, 2021
pulpet112 pushed a commit to infakt/Fotoapparat that referenced this pull request Apr 4, 2022
@AliAsadi @mqpioi
Add TopCrop option to ScaleType (RedApparat#372)
01c7550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Diolor Diolor Awaiting requested review from Diolor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AliAsadi @dmitry-zaitsev