Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BarChart, Tooltip, Legend, GlobalStyles, and shared utils + types into common directory #62

Merged
merged 5 commits into from
Oct 7, 2022

Conversation

terryttsai
Copy link
Contributor

Description of the change

Move BarChart, Tooltip, Legend, GlobalStyles, and shared types into common directory. Demonstrate publisher app importing from common directory.

This sets us up to import the same components into the agency dashboard app.

Type of change

All pull requests must have at least one of the following labels applied (otherwise the PR will fail):

Label Description
Type: Bug non-breaking change that fixes an issue
Type: Feature non-breaking change that adds functionality
Type: Breaking Change fix or feature that would cause existing functionality to not work as expected
Type: Non-breaking refactor change addresses some tech debt item or prepares for a later change, but does not change functionality
Type: Configuration Change adjusts configuration to achieve some end related to functionality, development, performance, or security
Type: Dependency Upgrade upgrades a project dependency - these changes are not included in release notes

Related issues

Closes #XXXX

Checklists

Development

This box MUST be checked by the submitter prior to merging:

  • Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

  • Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@terryttsai terryttsai requested a review from a team October 6, 2022 19:55
@terryttsai terryttsai changed the title Move BarChart, Tooltip, Legend, GlobalStyles, and shared types into common directory Move BarChart, Tooltip, Legend, GlobalStyles, and shared utils + types into common directory Oct 6, 2022
Copy link
Contributor

@mxosman mxosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a smooth transition! Just tried it out - did a yarn install and imported the SharedComponent from @justice-counts/common/components and it worked like a charm - and very quickly too!

Thanks for figuring this out and setting it up. Excited to see how this will work out for us!

@terryttsai
Copy link
Contributor Author

@mxosman awesome to hear it was a smooth transition for you!

Base automatically changed from terry/shared-components-1 to main October 7, 2022 17:29
@terryttsai terryttsai merged commit 91c0f6f into main Oct 7, 2022
@terryttsai terryttsai deleted the terry/shared-components-2 branch October 7, 2022 17:34
@lilidworkin
Copy link
Collaborator

@terryttsai this is fantastic! Awesome job researching this and coming up with such a good solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants