Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Upload: Playtesting Followup (Update Error/Warning/Success Page Copy) #53

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Data Upload: Playtesting Followup (Update Error/Warning/Success Page Copy) #53

merged 2 commits into from
Oct 4, 2022

Conversation

mxosman
Copy link
Contributor

@mxosman mxosman commented Oct 4, 2022 •
edited
Loading

Description of the change

Updates the copy for the following cases after a spreadsheet has been uploaded:

  1. Only warnings present
  2. Only errors present
  3. Warnings and errors present

Since warnings only appear on successful metrics, you can assume anything here with a warning was successfully ingested.

Warnings Only:
Screen Shot 2022-10-04 at 10 58 55 AM

Errors Only:
Screen Shot 2022-10-04 at 10 59 32 AM

Warnings and Errors:
Screen Shot 2022-10-04 at 10 57 42 AM

Related issues

Closes #52

Checklists

Development

This box MUST be checked by the submitter prior to merging:

  • Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

  • Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@mxosman mxosman requested a review from a team October 4, 2022 16:10
@mxosman mxosman changed the title Data Upload: Update Error/Warning/Success Page Copy Data Upload: Playtesting Followup (Update Error/Warning/Success Page Copy) Oct 4, 2022
lilidworkin
lilidworkin approved these changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@lilidworkin lilidworkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!! Great teamwork here

@mxosman mxosman merged commit bf7bbee into main Oct 4, 2022
@mxosman mxosman deleted the mahmoud/du-playtest-copy branch October 4, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilidworkin lilidworkin lilidworkin approved these changes

Assignees
No one assigned
Labels
Type: Non-breaking refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Frontend] Data Upload: Playtesting Followups
2 participants
@mxosman @lilidworkin