Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Upload: Playtesting Followups ('Add Data' Button Update, Support Email Update) #51

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Data Upload: Playtesting Followups ('Add Data' Button Update, Support Email Update) #51

merged 3 commits into from
Oct 4, 2022

Conversation

mxosman
Copy link
Contributor

@mxosman mxosman commented Oct 3, 2022 •
edited
Loading

Description of the change

  1. Changes the Add Data button to say Upload Data (open to other ideas on what it should say) with an icon.

Screen Shot 2022-10-03 at 4 26 32 PM

  1. Replaces all instances of [email protected] to [email protected]

Related issues

Contributes to #52

Checklists

Development

This box MUST be checked by the submitter prior to merging:

  • Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

  • Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@mxosman mxosman requested a review from a team October 3, 2022 21:28
terryttsai
terryttsai approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@terryttsai terryttsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about the use of adding an icon to the upload button but otherwise code looks good to me

@mxosman mxosman merged commit 0354b28 into main Oct 4, 2022
@mxosman mxosman deleted the mahmoud/du-playtest-fu branch October 4, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryttsai terryttsai terryttsai approved these changes

Assignees
No one assigned
Labels
Type: Non-breaking refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxosman @terryttsai