[Frontend][Review Metrics] Show old values #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilidworkin
reviewed
Sep 22, 2022
There was a problem hiding this comment.
@terryttsai can you upload a video or screenshot?! Excited to see this!
lilidworkin
reviewed
Sep 22, 2022
| @@ -280,11 +281,27 @@ const ReviewMetrics: React.FC = observer(() => { | |||
| value: string | number | null, | |||
| oldValue: string | number | null | |||
| ) => { | |||
| // Uncomment this for special treatment when a datapoint is newly added | |||
There was a problem hiding this comment.
Awesome! Thanks for putting the foundation here. I wonder if we should uncomment this for now, to facilitate debugging and also just to see how it feels? Maybe we can change the color or something instead of saying NEW?
There was a problem hiding this comment.
Not sure what the new symbol should be, it could also be less noisy to instead have an indication when the value has been unchanged. I'll leave that up to a follow-up PR
| // } | ||
| if (oldValue !== value) { | ||
| return ( | ||
| <DatapointsTableDetailsCell key={key}> |
|
Added a screenshot |
lilidworkin
approved these changes
Sep 22, 2022
|
Terry - this looks AMAZING!!! |
|
I know this is such a cool change!! What a great idea to do this 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Show old values in the Review Metrics page
Optional code to show when a metric is "new", as in the previous value was Null
Type of change
Related issues
Closes #XXXX
Checklists
Development
This box MUST be checked by the submitter prior to merging:
These boxes should be checked by the submitter prior to merging:
Code review
These boxes should be checked by reviewers prior to merging: