[Frontend][Review Metrics] Review Metrics Playtesting follow-ups #32

terryttsai · 2022-09-20T23:52:40Z

Description of the change

Fix overwritten values count
- Due to duplicate datapoint values in the Data Upload API response, we overcount overwritten values sometimes.
  - I filed a task to fix this on the backend, but for now, we can ignore duplicates in the frontend. I didn't put a TODO to undo this change because I don't think it's really necessary.
Change "Overwrites" to "Overwritten Values"
Allow continuing to the Review Metrics page even if the upload had errors

- Tweaked Review Metrics to make it more clear that their data has already been successfully uploaded - Changed the "Review 0 Uploaded Metrics" copy into a very simple No Metrics to Review

Type of change

All pull requests must have at least one of the following labels applied (otherwise the PR will fail):

Label	Description
Type: Bug	non-breaking change that fixes an issue
Type: Feature	non-breaking change that adds functionality
Type: Breaking Change	fix or feature that would cause existing functionality to not work as expected
Type: Non-breaking refactor	change addresses some tech debt item or prepares for a later change, but does not change functionality
Type: Configuration Change	adjusts configuration to achieve some end related to functionality, development, performance, or security
Type: Dependency Upgrade	upgrades a project dependency - these changes are not included in release notes

Related issues

Closes #XXXX

Checklists

Development

This box MUST be checked by the submitter prior to merging:

Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

This pull request has a descriptive title and information useful to a reviewer
This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
Potential security implications or infrastructural changes have been considered, if relevant

lilidworkin

Nice, thanks for knocking out all these fixes @terryttsai ! Appreciate how you enumerated everything that this PR does in the description too. 🙌

publisher/src/components/DataUpload/UploadErrorsWarnings.tsx

lilidworkin · 2022-09-21T13:31:30Z

publisher/src/components/DataUpload/UploadErrorsWarnings.tsx

-              Continue
-            </Button>
-          )}
+          <Button


Can you add a screenshot showing what this page looks like now if there are errors? I think there will be two calls to action -- a blue button on the left that says New Upload and a blue button on the right that says Continue. Is that right? That's fine for now (we need input on product and design on this) but just want to make sure I know the current behavior. Thanks!

Added screenshot in the description

Only the button on the right is blue

publisher/src/components/ReviewMetrics/ReviewMetrics.tsx

lilidworkin · 2022-09-21T13:36:10Z

publisher/src/components/ReviewMetrics/ReviewMetrics.tsx

+    return (
+      <DatapointsTableDetailsCell key={key}>
+        {parseFloat(
+          (typeof value === "string" ? parseFloat(value) : value).toFixed(2)


Actually not sure we want to do this -- I just commented on the doc, the issue with the "too many sig figs" was that what we were showing in the UI didn't match what was in the spreadsheet. I think if there are 2+ decimals in the spreadsheet, it's fine to show in the UI without rounding. LMK if that makes sense!

I'll remove this, I'd rather accurately portray what the user gave us, if it's showing up as too many sig figs from the backend, I'll leave it up to Nichelle to fix!

I'm not actually sure where it's showing up as too many sig figs though -- could be backend or could be frontend -- can you coordinate with @nichelle-hall to investigate?

This is coming from the backend

Removed logic to round decimals

lilidworkin · 2022-09-21T13:37:21Z

publisher/src/components/ReviewMetrics/ReviewMetrics.tsx

@@ -106,9 +106,6 @@ const ReviewMetrics: React.FC = observer(() => {
    }, {} as { [key: string]: number });

    metric.datapoints.forEach((dp) => {
-      if (dp.old_value !== null) {


Thanks for this fix!! Are the duplicate values on the backend causing any other issues? We should definitely fix the root cause on the backend, just curious if there are any other patches we need to do on the frontend in the meantime.

Yep, this is the issue to fix: #31, and on the frontend, I'm rooting out duplicate datapoints before using it and hadn't found any more issues with this.

Sounds good!

terryttsai · 2022-09-21T16:36:08Z

if my math is right, (6/16)^9 or 0.015% chance of a commit hash starting with 9 letters in a row
eccdddc

terryttsai · 2022-09-21T17:00:59Z

Added a very simple No Metrics to Review state for the review metrics page

lilidworkin

Awesome!!

terryttsai requested a review from a team September 20, 2022 23:52

fix overwritten values count

dc9b06f

terryttsai force-pushed the terry/review-metrics-fixes branch from 88774c3 to dc9b06f Compare September 20, 2022 23:53

round decimals to 2 places

03cdcc5

terryttsai changed the title ~~[Frontend][Review Metrics] Fix overwritten values count~~ [Frontend][Review Metrics] Review Metrics Playtesting fixes Sep 21, 2022

allow continuing if upload has errors

788b41d

terryttsai added Type: Bug Type: Feature and removed Type: Bug labels Sep 21, 2022

terryttsai changed the title ~~[Frontend][Review Metrics] Review Metrics Playtesting fixes~~ [Frontend][Review Metrics] Review Metrics Playtesting follow-ups Sep 21, 2022

lilidworkin reviewed Sep 21, 2022

View reviewed changes

terryttsai requested a review from lilidworkin September 21, 2022 16:32

remove rounding decimals

eccdddc

no metrics to review

3080909

lilidworkin approved these changes Sep 21, 2022

View reviewed changes

terryttsai merged commit c3c6b69 into main Sep 21, 2022

terryttsai deleted the terry/review-metrics-fixes branch September 21, 2022 18:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Frontend][Review Metrics] Review Metrics Playtesting follow-ups #32

[Frontend][Review Metrics] Review Metrics Playtesting follow-ups #32

terryttsai commented Sep 20, 2022 •

edited

Loading

lilidworkin left a comment

lilidworkin Sep 21, 2022

terryttsai Sep 21, 2022

terryttsai Sep 21, 2022

lilidworkin Sep 21, 2022

terryttsai Sep 21, 2022

lilidworkin Sep 21, 2022

terryttsai Sep 21, 2022

terryttsai Sep 21, 2022

lilidworkin Sep 21, 2022

terryttsai Sep 21, 2022

lilidworkin Sep 21, 2022

terryttsai commented Sep 21, 2022

terryttsai commented Sep 21, 2022

lilidworkin left a comment

[Frontend][Review Metrics] Review Metrics Playtesting follow-ups #32

[Frontend][Review Metrics] Review Metrics Playtesting follow-ups #32

Conversation

terryttsai commented Sep 20, 2022 • edited Loading

Description of the change

Type of change

Related issues

Checklists

Development

Code review

lilidworkin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

terryttsai commented Sep 21, 2022

terryttsai commented Sep 21, 2022

lilidworkin left a comment

Choose a reason for hiding this comment

terryttsai commented Sep 20, 2022 •

edited

Loading