Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Fix filtering metrics in review metrics page #30

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

terryttsai
Copy link
Contributor

Description of the change

Filter out metrics we are getting in the data upload api response if there are no updated datapoints for that metric

Type of change

All pull requests must have at least one of the following labels applied (otherwise the PR will fail):

Label Description
Type: Bug non-breaking change that fixes an issue
Type: Feature non-breaking change that adds functionality
Type: Breaking Change fix or feature that would cause existing functionality to not work as expected
Type: Non-breaking refactor change addresses some tech debt item or prepares for a later change, but does not change functionality
Type: Configuration Change adjusts configuration to achieve some end related to functionality, development, performance, or security
Type: Dependency Upgrade upgrades a project dependency - these changes are not included in release notes

Related issues

Closes #27

Checklists

Development

This box MUST be checked by the submitter prior to merging:

  • Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

  • Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@terryttsai terryttsai requested a review from a team September 20, 2022 19:52
Copy link
Contributor

@mxosman mxosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terryttsai terryttsai merged commit 8cf93db into main Sep 20, 2022
@terryttsai terryttsai deleted the terry/filter-metrics branch September 20, 2022 22:25
@lilidworkin
Copy link
Collaborator

lilidworkin commented Sep 21, 2022

Thanks so much for the quick fix @terryttsai ! Two questions:

  1. How does this affect the numbering? I imagine this will still cause the issue where now the numbers can start at, e.g. 4 instead of 1? Is that easy to fix? Totally fine to do that in a separate PR.
  2. How does this look if there are 0 metrics with datapoints (e.g. if you upload an example template)? I know we're still debating the right behavior for this state, and might not even show this page in this case, but in the meantime, maybe we can add a little message to this state that says something like "Uh oh, no data was found in the spreadsheet."

@terryttsai
Copy link
Contributor Author

This PR fixes the issue where the metric section number starts at, say, 4 instead of 1.

Right now, 0 metrics just say "Review 0 metrics" and the subtitle and the sections are empty.

We could render some sort of message on this page if there are 0 metrics to review for now, I'll take a stab at it.

@lilidworkin
Copy link
Collaborator

lilidworkin commented Sep 21, 2022

This PR fixes the issue where the metric section number starts at, say, 4 instead of 1.

oh awesome!

Right now, 0 metrics just say "Review 0 metrics" and the subtitle and the sections are empty. We could render some sort of message on this page if there are 0 metrics to review for now, I'll take a stab at it.

That would be great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend][Review Metrics] Fix filtering out datapoints with null values
3 participants