Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playtesting Followup: General Styling Fixes #194

Merged
merged 6 commits into from
Dec 3, 2022
Merged

Conversation

mxosman
Copy link
Contributor

@mxosman mxosman commented Dec 2, 2022

Description of the change

General styling-related clean up:

  • Reduce toast height

    • Screenshot 2022-12-02 at 12 55 18 PM to Screenshot 2022-12-02 at 12 55 34 PM
  • Reduce top padding on right panel in Metric Config

    • Screenshot 2022-12-02 at 2 44 43 PM
  • Adjust hover state of call out box to have a light blue background

    • Screenshot 2022-12-02 at 2 45 01 PM
  • Adjust onboarding faded container to be below the bordered header in data entry page

    • Screenshot 2022-12-02 at 2 46 16 PM to Screenshot 2022-12-02 at 2 45 58 PM
  • Hover state for active dimension should be blue and not grey

Related issues

Closes #193

Checklists

Development

This box MUST be checked by the submitter prior to merging:

  • Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

  • Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@mxosman mxosman marked this pull request as ready for review December 2, 2022 20:32
@mxosman mxosman requested a review from a team December 2, 2022 21:02
@mxosman mxosman merged commit 724fa59 into main Dec 3, 2022
@mxosman mxosman deleted the mahmoud/mc-style-fix branch December 3, 2022 00:23
Copy link
Collaborator

@lilidworkin lilidworkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these fixes @mxosman ! Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend][Playtesting Followup] General Styling Fixes
3 participants