-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Race & Ethnicities: Sorting Races & Quick Fix #190
Conversation
…ive metric bottom border in settings menu
</RaceEthnicitiesRow> | ||
))} | ||
{Object.entries(ethnicitiesByRace) | ||
.sort(sortRaces) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L83 is the only change in this file.
Object.values(ethnicities).find((ethnicity) => ethnicity.enabled) | ||
); | ||
{Object.entries(ethnicitiesByRace) | ||
.sort(sortRaces) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L219 is the only change in this file.
Despite it showing > 100 line changes - it's really only a small bit - a sorting function and a CSS line change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Good eye
Description of the change
Quick last minute items:
Related issues
Closes #180
Checklists
Development
This box MUST be checked by the submitter prior to merging:
These boxes should be checked by the submitter prior to merging:
Code review
These boxes should be checked by reviewers prior to merging: