Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race & Ethnicities: Sorting Races & Quick Fix #190

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

mxosman
Copy link
Contributor

@mxosman mxosman commented Nov 30, 2022

Description of the change

Quick last minute items:

  • Almost forgot about sorting the races (sorted based on the updated spec):

Screenshot 2022-11-30 at 4 10 48 PM

  • The active metric in the Settings menu metrics list lost its bottom blue border - it must've gotten lost somewhere in the overlapping PRs & rebases:

Screenshot 2022-11-30 at 4 11 53 PM

Related issues

Closes #180

Checklists

Development

This box MUST be checked by the submitter prior to merging:

  • Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

  • Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

</RaceEthnicitiesRow>
))}
{Object.entries(ethnicitiesByRace)
.sort(sortRaces)
Copy link
Contributor Author

@mxosman mxosman Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L83 is the only change in this file.

Object.values(ethnicities).find((ethnicity) => ethnicity.enabled)
);
{Object.entries(ethnicitiesByRace)
.sort(sortRaces)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L219 is the only change in this file.

@mxosman
Copy link
Contributor Author

mxosman commented Nov 30, 2022

Despite it showing > 100 line changes - it's really only a small bit - a sorting function and a CSS line change.

Copy link
Collaborator

@lilidworkin lilidworkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Good eye

@mxosman mxosman merged commit 270d9df into main Dec 1, 2022
@mxosman mxosman deleted the mahmoud/re-quick-followup branch December 1, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend][Publisher] Race & Ethnicities Playtesting Followups
2 participants