Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race & Ethnicities: Replace activeMetricKey and activeSystem with URL params #184

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

mxosman
Copy link
Contributor

@mxosman mxosman commented Nov 28, 2022

Description of the change

Replace all instances of the MetricConfig store's activeMetricKey and activeSystem with URL params & updates related Race & Ethnicities components. [Huge shout out to all of @ivan-kishko work with implementing the routing]

Related issues

Closes #185

Checklists

Development

This box MUST be checked by the submitter prior to merging:

  • Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

  • Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

Copy link
Contributor

@terryttsai terryttsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

@mxosman
Copy link
Contributor Author

mxosman commented Nov 29, 2022

Looks awesome!

Thank you, Terry!

@mxosman mxosman merged commit 35beab0 into main Nov 29, 2022
@mxosman mxosman deleted the mahmoud/re-use-params branch November 29, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants