[Fix] Settings: Metric Configuration Link

[mxosman]

Description of the change

Terry pointed out an issue with the Metric Configuration link in the Settings side menu where it shows up nothing when clicked (after you've selected a metric). After debugging, it looks like it navigates back to /settings/metric-config without the additional params. The solution is to update the Settings menu navigation to include the system params for the Metric Configuration link.

Related issues

Closes #XXXX

Checklists

Development

This box MUST be checked by the submitter prior to merging:

• Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

• Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

• This pull request has a descriptive title and information useful to a reviewer
• This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
• Potential security implications or infrastructural changes have been considered, if relevant

[terryttsai]

This looks like a good fix for the problem at hand, though here are some other cases to think about:

What if a user shares a link like /settings/metric-config without the system? If someone clicks on that link, will they see the blank screen? Should we re-route them to the right system in that case?

Or what if a user shares a link like /settings/metric-config?system=SOME_SYSTEM and the person that clicks on the link doesn't have that system? Should we also re-route them to the right system in that case?

[mxosman]

This looks like a good fix for the problem at hand, though here are some other cases to think about:

What if a user shares a link like /settings/metric-config without the system? If someone clicks on that link, will they see the blank screen? Should we re-route them to the right system in that case?

Or what if a user shares a link like /settings/metric-config?system=SOME_SYSTEM and the person that clicks on the link doesn't have that system? Should we also re-route them to the right system in that case?

Thanks, Terry - it's currently handling both cases you mentioned - Ivan already solved for them. Let me know when you get a chance to run it!

[terryttsai]

Fix works for me! LGTM!