Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Settings: Metric Configuration Link #182

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Conversation

mxosman
Copy link
Contributor

@mxosman mxosman commented Nov 28, 2022

Description of the change

Terry pointed out an issue with the Metric Configuration link in the Settings side menu where it shows up nothing when clicked (after you've selected a metric). After debugging, it looks like it navigates back to /settings/metric-config without the additional params. The solution is to update the Settings menu navigation to include the system params for the Metric Configuration link.

Related issues

Closes #XXXX

Checklists

Development

This box MUST be checked by the submitter prior to merging:

  • Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

  • Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@mxosman mxosman requested a review from a team November 28, 2022 17:44
Copy link
Contributor

@terryttsai terryttsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good fix for the problem at hand, though here are some other cases to think about:

What if a user shares a link like /settings/metric-config without the system? If someone clicks on that link, will they see the blank screen? Should we re-route them to the right system in that case?

Or what if a user shares a link like /settings/metric-config?system=SOME_SYSTEM and the person that clicks on the link doesn't have that system? Should we also re-route them to the right system in that case?

@mxosman
Copy link
Contributor Author

mxosman commented Nov 28, 2022

This looks like a good fix for the problem at hand, though here are some other cases to think about:

What if a user shares a link like /settings/metric-config without the system? If someone clicks on that link, will they see the blank screen? Should we re-route them to the right system in that case?

Or what if a user shares a link like /settings/metric-config?system=SOME_SYSTEM and the person that clicks on the link doesn't have that system? Should we also re-route them to the right system in that case?

Thanks, Terry - it's currently handling both cases you mentioned - Ivan already solved for them. Let me know when you get a chance to run it!

Copy link
Contributor

@terryttsai terryttsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix works for me! LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants