Race & Ethnicities (Playtesting Followup): Grey Out Grid When Disaggregation Is Disabled #178

mxosman · 2022-11-23T19:32:24Z

Description of the change

When disaggregation is disabled, the grid area is grey'd-out.

Demo:

Screen.Recording.2022-11-23.at.1.28.11.PM.mov

Contributes to #180

This box MUST be checked by the submitter prior to merging:

Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

Tests have been written to cover the code changed/added as part of this pull request

These boxes should be checked by reviewers prior to merging:

This pull request has a descriptive title and information useful to a reviewer
This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
Potential security implications or infrastructural changes have been considered, if relevant

mxosman · 2022-11-23T22:06:06Z

publisher/src/components/MetricConfiguration/RaceEthnicitiesGrid.tsx

+    return (
+      <RaceEthnicitiesBreakdownContainer
+        disaggregationEnabled={disaggregationEnabled}
+      >


All indentation below this.

lilidworkin · 2022-11-28T16:09:37Z

Nice! Thanks @mxosman

Add grid overlay when disaggregation is disabled

5f17d12

mxosman added the Type: Non-breaking refactor label Nov 23, 2022

mxosman marked this pull request as ready for review November 23, 2022 22:00

mxosman commented Nov 23, 2022

View reviewed changes

mxosman requested a review from a team November 23, 2022 22:06

terryttsai approved these changes Nov 23, 2022

View reviewed changes

mxosman merged commit 4c02edd into main Nov 28, 2022

mxosman deleted the mahmoud/re-grid-overlay branch November 28, 2022 19:19