Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display report creation error when there are overlapping report dates #164

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

nichelle-hall
Copy link
Contributor

@nichelle-hall nichelle-hall commented Nov 16, 2022

Description of the change

When creating reports with the same start and end date, I was seeing a generic response. This PR makes a change in the FE where we now check what the description is before displaying the toast. We deprecated all api responses that were not 500 because only 500 responses show up in our logs. As a result, the check to see if the response code is 400 to display the toast with the specific error date error was always ignored.

Screen.Recording.2022-11-16.at.12.45.59.PM.mov

Related issues

Closes #XXXX

Checklists

Development

This box MUST be checked by the submitter prior to merging:

  • Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

  • Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@nichelle-hall nichelle-hall added the bug Something isn't working label Nov 16, 2022
@nichelle-hall nichelle-hall added Type: Bug and removed bug Something isn't working labels Nov 16, 2022
@nichelle-hall nichelle-hall changed the title display report creation error when there is overlapping dates display report creation error when there are overlapping report dates Nov 16, 2022
Copy link
Collaborator

@lilidworkin lilidworkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@nichelle-hall nichelle-hall merged commit 934c3b2 into main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants