Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert eslint rule to disable requiring react in jsx scope #163

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

terryttsai
Copy link
Contributor

@terryttsai terryttsai commented Nov 15, 2022

Description of the change

This PR reverts the configuration change made here

When we turn off react/react-in-jsx-scope, the eslint rule doesn't seem to stay off for some reason. If I start yarn dev in a new tab, usually we get no errors, but when modifying a file and recompiling, we start getting react/react-in-jsx-scope errors again. I'm at a loss as to why this is happening, and by now we've reimported React in most of our files to get around this issue.

So this PR just reinstates these rules.

Type of change

All pull requests must have at least one of the following labels applied (otherwise the PR will fail):

Label Description
Type: Bug non-breaking change that fixes an issue
Type: Feature non-breaking change that adds functionality
Type: Breaking Change fix or feature that would cause existing functionality to not work as expected
Type: Non-breaking refactor change addresses some tech debt item or prepares for a later change, but does not change functionality
Type: Configuration Change adjusts configuration to achieve some end related to functionality, development, performance, or security
Type: Dependency Upgrade upgrades a project dependency - these changes are not included in release notes

Related issues

Closes #XXXX

Checklists

Development

This box MUST be checked by the submitter prior to merging:

  • Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

  • Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@terryttsai terryttsai requested a review from a team November 15, 2022 23:28
Copy link
Collaborator

@lilidworkin lilidworkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @terryttsai ! This is indeed quite weird, but agreed that reverting is the way to go for now.

@terryttsai terryttsai merged commit 4f05579 into main Nov 16, 2022
@terryttsai terryttsai deleted the terry/revert-no-import-react branch November 16, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants