revert eslint rule to disable requiring react in jsx scope #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR reverts the configuration change made here
When we turn off
react/react-in-jsx-scope
, the eslint rule doesn't seem to stay off for some reason. If I startyarn dev
in a new tab, usually we get no errors, but when modifying a file and recompiling, we start gettingreact/react-in-jsx-scope
errors again. I'm at a loss as to why this is happening, and by now we've reimported React in most of our files to get around this issue.So this PR just reinstates these rules.
Type of change
Related issues
Closes #XXXX
Checklists
Development
This box MUST be checked by the submitter prior to merging:
These boxes should be checked by the submitter prior to merging:
Code review
These boxes should be checked by reviewers prior to merging: