Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FormStore: Remove Context Validation #161

Merged
merged 2 commits into from
Nov 15, 2022
Merged

FormStore: Remove Context Validation #161

merged 2 commits into from
Nov 15, 2022

Conversation

mxosman
Copy link
Contributor

@mxosman mxosman commented Nov 15, 2022 •
edited
Loading

Description of the change

Removes context validation from the FormStore and updates the key parameter names to be more readable.

Related issues

Closes #136

Checklists

Development

This box MUST be checked by the submitter prior to merging:

  • Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

  • Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@mxosman mxosman requested a review from a team November 15, 2022 21:12
@mxosman mxosman merged commit 2c538e5 into main Nov 15, 2022
@mxosman mxosman deleted the mahmoud/de-validation-cleanup branch November 15, 2022 22:15
lilidworkin
lilidworkin reviewed Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@lilidworkin lilidworkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mxosman !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilidworkin lilidworkin lilidworkin left review comments

@terryttsai terryttsai terryttsai approved these changes

Assignees
No one assigned
Labels
Type: Non-breaking refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Frontend][Publisher] Remove Context Validation from FormStore
3 participants
@mxosman @terryttsai @lilidworkin