[1.12.2] Possible Memory Leak when the Armor from Rats renders.

[SonicX8000]

In a modded survival world that has Rats: RatN-Edition installed... I got a Pirat Hat and gave it to one of my tamed rats to wear since... well... arrr, pirate rat. Now... I didn't think anything of it but overtime I noticed something was off.

If the Armor from Rats renders whether it be on the inventory screen, in your eyesight view or if using an addon to show a preview of the mob such as ToroHUD... the Memory usage gradually goes up overtime. Not sure if it'll crash or something but my PC did warn me of having low ram even though I have 32GB of it installed. (I have 12GB allocated as it has 300+ mods installed.)

Now... in this instance for testing... the only mods installed are...

Minecraft: 1.12.2
Forge: 14.23.5.2854

Mods: 3
jei_1.12.2-4.16.1.302
llibrary-1.7.19-1.12.2
rats-3.2.19-1.12.2

Here's an image of my memory usage in task manager. I am aware that it goes up overtime but it stops rising if I remain still in one spot and don't move or anything... this is what I have...

Left: I am wearing almost full diamond armor and my memory usage is about 6.2GB or so. It seems to have stopped around there so that's when I took the screen cap for it.

Right: I put on the Pirat Hat and left the PC on for maybe an hour and... my usage has gone up to 8.3GB and still climbing. It'll keep going up until you remove the Pirat Hat... as in... it doesn't render on your screen.

=====

Doing some looking around, apparently this was happening in the original mod as well, something about it rendering the armor every tick. I found out about this from the issue here.

Electroblob77/Wizardry#648

It might be all the armors in this case, since in the issue the Chef's Hat was mentioned and I got it with the Pirat Hat.

[Davoleo]

I have pushed a new version of Rats that should fix the memory leak, please tell me if you're still somehow experiencing it
Release Here: https://www.curseforge.com/minecraft/mc-mods/rats-ratn-edition/files/3439601

[SonicX8000]

It appears to be fixed after testing it in my modded survival world by having my two rat followers wear a Piper Hat & a Top Hat. Have not seen the memory usage slowly build up overtime.

However... it appears to crash with only these files...

jei_1.12.2-4.16.1.302
llibrary-1.7.20-1.12.2
rats-3.2.20-1.12.2

Crash:
https://hastebin.com/nunomayalu.properties

Now I am not sure why it loads without issue with a bunch of mods and that it only crashes with the above mods listed.

[Davoleo]

yeah, I've archived the faulty version and uploaded a new working version, thanks for the prompty answers

[owenthewizard]

This took me so long to figure out. The damaged santa hat I was wearing caused my RAM to fill up and GC to take almost 10 seconds every few seconds.