Migrate rich billing portals to common billing portals #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamaltman
reviewed
Feb 19, 2024
| description: ID of the plan. | ||
| maxLength: 50 | ||
| example: plan_0YV7DENSVGDBW9S71XZNNYYQ0X | ||
| - $ref: ./SubscriptionOrderPlan.yaml |
There was a problem hiding this comment.
This has these required props.
required:
- name
- currency
- productId
- pricing
- recurringInterval
I don't understand why all of these are required and id prop.
There was a problem hiding this comment.
Why is this marked as resolved but nothing changed?
There was a problem hiding this comment.
It was changed. Now it's FlexiblePlan as I mentioned in Slack thread. So, you can send "id" only or full Plan content:
ddd1e50
adamaltman
approved these changes
Feb 21, 2024
ashkarpetin
approved these changes
Feb 21, 2024
This was referenced Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes rich billing portals and migrates its additional functionality to common billing portals
Checklist