refactor: recursive async function issue in handle_item
#695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syjn99
changed the title
handle_item
KolbyML
approved these changes
Aug 13, 2025
Contributor
KolbyML
left a comment
KolbyML
left a comment
There was a problem hiding this comment.
looks good thank you for your contribution!
allnil
pushed a commit
to loadnetwork/ream
that referenced
this pull request
Aug 18, 2025
refactor: recursive async function issue in handle_item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Yesterday, there was a new Rust nightly release. This introduced a new solver, which catches bad Rust patterns more accurately.
My last PR (#679) has an anti-pattern (e.g., using
Box::pinto make it run). It makes our CI (cargo udeps) fail since #694. See the action result.How was it fixed?
This PR refactors
LeanChainServicemethods by avoiding recursive asynchronous function calls usingmpsc. (Decoupling the call cycle). Therefore, ourudepsis much happier right now :)I also added to log
source_slotin each vote as this shows the chain finalization much clear.To-Do