refactor: remove legacy code #7183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `EmptyError` cannot be used if `target` is below ES2015
BREAKING CHANGE: `NotFoundError` cannot be used if `target` is below ES2015
BREAKING CHANGE: `SequenceError` cannot be used if `target` is below ES2015
BREAKING CHANGE: `TimeoutError` cannot be used if `target` is below ES2015
BREAKING CHANGE: `ObjectUnsubscribedError` cannot be used if `target` is below ES2015
BREAKING CHANGE: `ArgumentOutOfRangeError` cannot be used if `target` is below ES2015
BREAKING CHANGE: `AjaxError` cannot be used if `target` is below ES2015 BREAKING CHANGE: `AjaxTimeoutError` cannot be used if `target` is below ES2015
Since the type specifies that `errors` is an array and the only place where
this class is used is wrapped in `if (errors) {` I removed the meaningless
ternary operator.
BREAKING CHANGE: `UnsubscriptionError` cannot be used if `target` is below ES2015
BREAKING CHANGE: `ajax` no longer supports IE
|
Hi, can you tell my why you closed this PR? I stumbled across the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main points:
If you know any other places that are legacy and need to be deleted/refactor, welcome to the comments.
BREAKING CHANGE:
EmptyErrorcannot be used iftargetis below ES2015BREAKING CHANGE:
NotFoundErrorcannot be used iftargetis below ES2015BREAKING CHANGE:
SequenceErrorcannot be used iftargetis below ES2015BREAKING CHANGE:
TimeoutErrorcannot be used iftargetis below ES2015BREAKING CHANGE:
ObjectUnsubscribedErrorcannot be used iftargetis below ES2015BREAKING CHANGE:
ArgumentOutOfRangeErrorcannot be used iftargetis below ES2015BREAKING CHANGE:
AjaxErrorcannot be used iftargetis below ES2015BREAKING CHANGE:
AjaxTimeoutErrorcannot be used iftargetis below ES2015BREAKING CHANGE:
UnsubscriptionErrorcannot be used iftargetis below ES2015BREAKING CHANGE:
ajaxno longer supports IERelated issue (if exists): #6367