Delete symbols that are marked for deletion in v8

[demensky]

I deleted all symbols that were completely marked for deletion. There are no signature removals in this PR!

Separately, I want to clarify that refCount is also removed, although @deprecated does not specify the version in which it needs to be removed. I came to this conclusion because the version was specified in ConnectableObservable.

BREAKING CHANGE: The merge operator is no longer available. Use mergeWith.
BREAKING CHANGE: The zip operator is no longer available. Use zipWith.
BREAKING CHANGE: The publishLast operator is no longer available. Use share({ connector: () => new AsyncSubject(), resetOnError: false, resetOnComplete: false, resetOnRefCountZero: false }) or connectable(source$, { connector: () => new AsyncSubject(), resetOnDisconnect: false }). Multicasting.
BREAKING CHANGE: The publishReplay operator is no longer available. Use share({ connector: () => new ReplaySubject(1), resetOnError: false, resetOnComplete: false, resetOnRefCountZero: false }) or connectable(source$, { connector: () => new ReplaySubject(1), resetOnDisconnect: false }) Multicasting.
BREAKING CHANGE: The publishBehavior operator is no longer available. Use share({ connector: () => new BehaviorSubject(0), resetOnError: false, resetOnComplete: false, resetOnRefCountZero: false }) or connectable(source$, { connector: () => new BehaviorSubject(0), resetOnDisconnect: false }). Multicasting.
BREAKING CHANGE: The publish operator is no longer available. Use share({ resetOnError: false, resetOnComplete: false, resetOnRefCountZero: false }) or connectable(source$, { connector: () => new Subject(), resetOnDisconnect: false }). Multicasting.
BREAKING CHANGE: The multicast operator is no longer available. Use share({ connector: () => new Subject() }) or connectable(source$, {connector: () => new Subject() }) Multicasting.
BREAKING CHANGE: The refCount operator is no longer available. Multicasting.
BREAKING CHANGE: The ConnectableObservable observable is no longer available. Multicasting.
BREAKING CHANGE: The race operator is no longer available. Use raceWith.
BREAKING CHANGE: The pluck('foo', 'bar') operator is no longer available. Use map(x => x?.foo?.bar).
BREAKING CHANGE: The pairs function is no longer available. Use from(Object.entries(obj)) instead pairs(obj).

Related issue (if exists): #6367

[benlesh]

This is mostly okay. The only thing I'd like to change is to make sure that alternatives for the removed operators are in the BREAKING CHANGE notes. (for example, using share({ connector: () => new AsyncSubject(), resetOnError: false, resetOnComplete: false, resetOnRefCountZero: false }) or connectable(source$, { connector: () => new AsyncSubject() }) instead of publishLast())

To understand why I'd like these changed: This is what I use to generate the CHANGELOG.md file. And it's per commit. :) I don't want to rebase your commits because you'll lose credit for them.

[benlesh]

nit: It would be great if while we were changing these we stopped using the rxjs/operators exports and started using the rxjs exports.

[demensky]

I have already researched this issue. I planned to make a separate PR. We can even include an eslint rule for this:

"@typescript-eslint/no-restricted-imports": [
  "error",
  { "name": "rxjs/operators", "message": "Use 'rxjs'" }
],

[demensky]

It's just that side changes add a lot of noise to the diff and make them hard to review.

[benlesh]

Makes sense to me. FYI: when I say "nit" I means I'm not going to block a merge on it. Just pointing something out. (As you may have noticed, if it was a "big deal" I'd have just added a commit to fix it).

[demensky]

Voila!

[demensky]

I'll probably add the eslint rule to the PR for #5078.

[benlesh]

Honestly, I think the links in the BREAKING CHANGE message are fine. Approved.

[demensky]

I almost had time to update all the commits before your comment. 😁

[demensky]

@benlesh, I also removed the pairs function, which I overlooked.

[jakovljevic-mladen]

@demensky, thanks for letting me know about this PR which I completely forgot about. In my #7181, I also tried updating docs while removing the pluck operator. This means that I have updated some files that were referencing removed pluck operator.

If you didn't do it (I haven't entirely reviewed this PR), if you have enough time and you'd like to update docs, please check these files:

• docs_app/content/guide/operators.md and potentially other files from docs_app/content/guide/ folder that referenced removed stuff - migrations can stay for now, old ones will have to be removed, and the new ones will have to be written in a new guide;
• docs_app/tools/decision-tree-generator/src/tree.yml: please either update or completely remove references to removed stuff - many removed stuff has been renamed (merge -> mergeWith), so please try using renamed versionsif possible before removing children and labels;
• remove references from JSDoc comments in other operators/functions (like I have for pluck in map operator).

I'm completely fine with updating the docs in a new commit or PR.

[demensky]

@jakovljevic-mladen, I have updated the PR according to your suggestions. In the tree.yml file, changing merge to mergeWith does not make much sense because merge exists as a function.

[jakovljevic-mladen]

Changes look good to me, but there are still some docs issues that could be improved. If you go to the docs_app folder, install dependencies (npm i) and run docs script (npm run docs), you may notice that there's a nice utility tool that reports issues with links:

If possible, and if it doesn't make too much hassle for you, please try removing those as well.

Also, there's one mention of empty in operators.md file:

[`empty`](/api/index/function/empty)

Can you remove this one as well? But, since you create a new commit per removal, I'm completely OK with those changes to go in another commit/PR.

[demensky]

@jakovljevic-mladen, I've fixed the broken links in the documentation.

[jakovljevic-mladen]

LGTM. Thanks a lot for fixing all suggestions.

[benlesh]

Oh no! I came here to merge this but there are conflicts. @demensky can you please fix the conflicts? :)

[demensky]

@benlesh Done!