feat: removed deprecated call pattern with resultSelector
#7156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elector) call pattern BREAKING CHANGE: `concatMapTo(observable, resultSelector)` call pattern is no longer available. [Read more](https://rxjs.dev/deprecations/resultSelector).
…) call pattern BREAKING CHANGE: `concatMap(project, resultSelector)` call pattern is no longer available. [Read more](https://rxjs.dev/deprecations/resultSelector).
…ector) call pattern BREAKING CHANGE: `mergeMapTo(observable, resultSelector)` call pattern is no longer available. [Read more](https://rxjs.dev/deprecations/resultSelector).
…or) call pattern BREAKING CHANGE: `exhaustMap(project, resultSelector)` call pattern is no longer available. [Read more](https://rxjs.dev/deprecations/resultSelector).
…call pattern BREAKING CHANGE: `mergeMap(project, resultSelector)` call pattern is no longer available. [Read more](https://rxjs.dev/deprecations/resultSelector).
…elector) call pattern BREAKING CHANGE: `switchMapTo(observable, resultSelector)` call pattern is no longer available. [Read more](https://rxjs.dev/deprecations/resultSelector).
…) call pattern BREAKING CHANGE: `switchMap(project, resultSelector)` call pattern is no longer available. [Read more](https://rxjs.dev/deprecations/resultSelector).
benlesh
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Approved. I had to fix a couple of things.
The biggest callout @demensky is that I changed switchScan to use a direct subscription, as tap is a little heavy-handed. It might be better if we at some point just made a switchInternals helper for the library like we did with mergeMap et al... or even just made switchMap based on switchScan... but I'll have to think about that. This is fine for now.
|
Great work, @demensky, thank you for saving me the time here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: see individual commits.
BREAKING CHANGE: All deprecated call pattern with
resultSelectoris no longer available. Read more.Related issue (if exists): #6367