Skip to content

Conversation

@jakovljevic-mladen
Copy link
Member

I renamed skipLast's parameter from skipCount to count for two reasons:

  • the docs in the first sentence is still referring to this parameter named as count;
  • to have to same name as the other operators (e.g.skip, take or takeLast).

@benlesh
Copy link
Member

benlesh commented Oct 2, 2020

I'm not sure this makes the code any better. If anything, it's less readable now with count, counter and currentCount. Admittedly it wasn't great before, but at least it was obvious which one came from the argument.

@benlesh
Copy link
Member

benlesh commented Oct 2, 2020

@jakovljevic-mladen I've added a related PR, and I'd be happy if you reviewed it: #5788

@benlesh benlesh closed this Oct 2, 2020
@jakovljevic-mladen jakovljevic-mladen deleted the skipLast_parameter_name_change branch October 3, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants