Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bindNodeCallback): ensure underlying function is not called twice… #5780

Merged
merged 1 commit into from
Sep 30, 2020
Merged

fix(bindNodeCallback): ensure underlying function is not called twice… #5780

merged 1 commit into from
Sep 30, 2020

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Sep 29, 2020

… during subscription

  • Fixes an issue where bindNodeCallback observables would call the underlying function twice if it has not called back yet, and more than one subscription occurred.
  • Reduces the size of the implementation
  • Adds more comments to the file.

@benlesh
fix(bindNodeCallback): ensure underlying function is not called twice…
e557cff 
… during subscription

- Fixes an issue where `bindNodeCallback` observables would call the underlying function twice if it has not called back yet, and more than one subscription occurred.
- Reduces the size of the implementation
- Adds more comments to the file.
@benlesh benlesh requested a review from cartant September 29, 2020 22:56
@benlesh
Copy link
Member Author

benlesh commented Sep 29, 2020

Node that bindCallback will have exactly the same issue.

@benlesh benlesh merged commit 74aa4b2 into ReactiveX:master Sep 30, 2020
@benlesh benlesh mentioned this pull request Sep 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartant cartant cartant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benlesh @cartant