Skip to content

Conversation

@cartant
Copy link
Collaborator

@cartant cartant commented Aug 18, 2020

Description:

This PR adds the synchronous 'firehose' test - from PR #5650 - to all operators for which it is meaningful.

The following operators currently fail and are skipped:

  • catchError
  • exhaust
  • exhaustMap
  • multicast
  • raceWith
  • refCount
  • repeat
  • repeatWhen
  • retry
  • retryWhen
  • share
  • shareReplay
  • single
  • skipLast
  • throttle
  • timeout
  • timeoutWith

Some of the failures are likely dependent - e.g. share fails because either multicast or refCount fails.

Whether or not the failures should be fixed in this PR or in subsequent PRs, IDK. Anyway, at least we now have the tests.

Also, the PR renames some spec source files to match the operator name and to identify 'legacy' tests - some existing files were identified as such, but others were not.

Related issue (if exists): #5650

@cartant cartant requested a review from benlesh August 18, 2020 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants