Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs]: Operator single is missing the description, and examples #4616

Closed
2 of 5 tasks
BioPhoton opened this issue Mar 4, 2019 · 3 comments
Closed
2 of 5 tasks

[docs]: Operator single is missing the description, and examples #4616

BioPhoton opened this issue Mar 4, 2019 · 3 comments
Labels
docs Issues and PRs related to documentation help wanted Issues we wouldn't mind assistance with.

Comments

@BioPhoton
Copy link
Contributor

BioPhoton commented Mar 4, 2019 •
edited
Loading

Please check those that apply

  • typo
  • documentation doesn't exist
  • documentation needs clarification
  • error(s) in example
  • needs example

Description Of The Issue

The description and example section is missing for the single operator
@niklas-wortmann niklas-wortmann added help wanted Issues we wouldn't mind assistance with. docs Issues and PRs related to documentation labels Mar 4, 2019
@weitalu
Copy link
Contributor

weitalu commented Mar 7, 2019

I would like to help with this issue, created a local commit,

but I could not submit the PR because I don't have enough access to create a remote branch.

What should I do ?

(Was following this guideline https://github.com/ReactiveX/rxjs/blob/master/CONTRIBUTING.md#submitting-a-pull-request-pr)

@niklas-wortmann
Copy link
Member

@weitalu I think the confusing point here is (also not mentioned in the document), you need to fork the rxjs repo, push to a branch of your private forked repository and afterwards github will propose you to create a merge request for that branch to the rxjs repo. This should basically work. When there is anything unclear or still not working, feel free to contact me! Thanks for helping out with this!

weitalu pushed a commit to weitalu/rxjs that referenced this issue Mar 7, 2019
docs(single): update docs for single with description and example (Re…
56e31e9 
…activeX#4616)

* docs(single) Updated docs for single with description and example
@weitalu weitalu mentioned this issue Mar 7, 2019
Closed
weitalu pushed a commit to weitalu/rxjs that referenced this issue Mar 7, 2019
docs(single): Updated docs for single with description and example (R…
3b1dcb2 
…eactiveX#4616)

Updated docs for single with description and example
@weitalu weitalu mentioned this issue Mar 7, 2019
Merged
@BioPhoton BioPhoton changed the title Operator single is missing the description, and examples [docs]: Operator single is missing the description, and examples Mar 29, 2019
weitalu pushed a commit to weitalu/rxjs that referenced this issue Apr 1, 2019
docs(single): Updated docs for single with description and example (R…
0ce4060 
…eactiveX#4616)

Updated docs for  the requested changes
niklas-wortmann pushed a commit that referenced this issue Apr 3, 2019
@weitalu @niklas-wortmann
docs(single): Updated docs for single with description and example (#… (
f67a22f 
#4623)

* docs(single): Updated docs for single with description and example (#4616)

Updated docs for single with description and example

* docs(single): Updated docs for single with description and example (#4616)

Updated docs for  the requested changes
BioPhoton pushed a commit to BioPhoton/rxjs that referenced this issue May 15, 2019
@weitalu @BioPhoton
docs(single): Updated docs for single with description and example (#… (
7a4a6e7 
ReactiveX#4623)

* docs(single): Updated docs for single with description and example (ReactiveX#4616)

Updated docs for single with description and example

* docs(single): Updated docs for single with description and example (ReactiveX#4616)

Updated docs for  the requested changes
@KeijiBranshi KeijiBranshi mentioned this issue May 2, 2020
Open
89 tasks
@niklas-wortmann
Copy link
Member

closed by #4623

@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
docs Issues and PRs related to documentation help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@niklas-wortmann @BioPhoton @weitalu