-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rx.Observable.ajax onProgress only set for Upload #2833
Comments
It seems to me that AjaxObservable needs to make a distinction between upload progress and download progress. You can get progress events by adding the line Would it make sense to split the |
It has been more than a year now. What is status of this? |
- Fixes a bunch of tests that were slightly off or had bad assumptions - Adds two new features: `includeUploadProgress` and `includeDownloadProgress` that will add additional events to the output stream before the event that is usually emitted. Resolved ReactiveX#2833
- Fixes a bunch of tests that were slightly off or had bad assumptions - Adds two new features: `includeUploadProgress` and `includeDownloadProgress` that will add additional events to the output stream before the event that is usually emitted. Resolves ReactiveX#2833
Sorry this took a VERY long time. It wasn't really high-demand, and it took a while to get back to this. There is now a PR #6001 that adds streaming updates for progress, rather than use the |
Hi there,
I hadn't been able to make
progressSubscriber.next
to fire on a Rx.Observable.ajax instance, when downloading. Checking the code and the log I found that you setonprogress
for the upload but you removed the one for download.As
window.XDomainRequest
is only available for IE 8 & 9, then on modern browsersonprogress
is not assigned.rxjs/src/observable/dom/AjaxObservable.ts
Lines 332 to 336 in 7bb8280
Did you avoid setting
xhr.onprogress = xhrProgress
for any specific reason? Or, Should it be there next toxhr.upload.onprogress = xhrProgress
?Thanks
SntsDev
The text was updated successfully, but these errors were encountered: