Skip to content

Commit

Permalink
build(package): refactoring build scripts with project ref / incremen…
Browse files Browse the repository at this point in the history
…tal (#5032)

* build(tsconfig): enable incremental, project references

* build(package): generate package using top level root as-is

* test(sideeffect): update import site snapshot

* build(package): support subpath alias with top-level root

* ci(circle): update ci scripts

* build(package): remove unused dependencies

* build(package): ensure alias script not throw

* test(mocha): run test directly from compiled results

* build(tsconfig): fix sourceroot for source, typemaps

BREAKING CHANGES: esm2015 renamed to esm. (though this is undocumented)
scoped package @reactivex/rxjs is being deprecated
  • Loading branch information
kwonoj authored and benlesh committed Oct 15, 2019
1 parent eddb2d8 commit de6f1ef
Show file tree
Hide file tree
Showing 41 changed files with 316 additions and 710 deletions.
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- checkout
- *restore_cache
- run: npm i
- run: npm run build_all
- run: npm run build:package
- persist_to_workspace:
root: .
paths:
Expand Down Expand Up @@ -63,7 +63,7 @@ jobs:
steps:
- attach_workspace: *attach_options
- run: npm i --no-save [email protected].*
- run: npm run build_cjs
- run: npm run compile

workflows:
version: 2
Expand Down
8 changes: 8 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,18 @@ img/
spec-js/
spec-build/
.out/
.tmp/

ajax/
fetch/
operators/
testing/
webSocket/

# Misc
npm-debug.log
.DS_STORE
*.tgz

# The check-side-effects package generates and deletes this file.
# If the process is killed, it will be left behind.
Expand Down
137 changes: 0 additions & 137 deletions .make-packages.js

This file was deleted.

7 changes: 0 additions & 7 deletions .npmignore

This file was deleted.

1 change: 0 additions & 1 deletion index.js

This file was deleted.

24 changes: 12 additions & 12 deletions integration/side-effects/side-effects.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,48 +5,48 @@
"expectedOutput": "./snapshots/esm5/index.js"
},
{
"esModules": "../../dist/esm2015/index.js",
"expectedOutput": "./snapshots/esm2015/index.js"
"esModules": "../../dist/esm/index.js",
"expectedOutput": "./snapshots/esm/index.js"
},
{
"esModules": "../../dist/esm5/ajax/index.js",
"expectedOutput": "./snapshots/esm5/ajax.js"
},
{
"esModules": "../../dist/esm2015/ajax/index.js",
"expectedOutput": "./snapshots/esm2015/ajax.js"
"esModules": "../../dist/esm/ajax/index.js",
"expectedOutput": "./snapshots/esm/ajax.js"
},
{
"esModules": "../../dist/esm5/fetch/index.js",
"expectedOutput": "./snapshots/esm5/fetch.js"
},
{
"esModules": "../../dist/esm2015/fetch/index.js",
"expectedOutput": "./snapshots/esm2015/fetch.js"
"esModules": "../../dist/esm/fetch/index.js",
"expectedOutput": "./snapshots/esm/fetch.js"
},
{
"esModules": "../../dist/esm5/operators/index.js",
"expectedOutput": "./snapshots/esm5/operators.js"
},
{
"esModules": "../../dist/esm2015/operators/index.js",
"expectedOutput": "./snapshots/esm2015/operators.js"
"esModules": "../../dist/esm/operators/index.js",
"expectedOutput": "./snapshots/esm/operators.js"
},
{
"esModules": "../../dist/esm5/testing/index.js",
"expectedOutput": "./snapshots/esm5/testing.js"
},
{
"esModules": "../../dist/esm2015/testing/index.js",
"expectedOutput": "./snapshots/esm2015/testing.js"
"esModules": "../../dist/esm/testing/index.js",
"expectedOutput": "./snapshots/esm/testing.js"
},
{
"esModules": "../../dist/esm5/webSocket/index.js",
"expectedOutput": "./snapshots/esm5/websocket.js"
},
{
"esModules": "../../dist/esm2015/webSocket/index.js",
"expectedOutput": "./snapshots/esm2015/websocket.js"
"esModules": "../../dist/esm/webSocket/index.js",
"expectedOutput": "./snapshots/esm/websocket.js"
}
]
}
1 change: 1 addition & 0 deletions integration/side-effects/snapshots/esm/ajax.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

1 change: 1 addition & 0 deletions integration/side-effects/snapshots/esm/fetch.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

7 changes: 7 additions & 0 deletions integration/side-effects/snapshots/esm/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
var NotificationKind;

(function(NotificationKind) {
NotificationKind["NEXT"] = "N";
NotificationKind["ERROR"] = "E";
NotificationKind["COMPLETE"] = "C";
})(NotificationKind || (NotificationKind = {}));
7 changes: 7 additions & 0 deletions integration/side-effects/snapshots/esm/operators.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
var NotificationKind;

(function(NotificationKind) {
NotificationKind["NEXT"] = "N";
NotificationKind["ERROR"] = "E";
NotificationKind["COMPLETE"] = "C";
})(NotificationKind || (NotificationKind = {}));
7 changes: 7 additions & 0 deletions integration/side-effects/snapshots/esm/testing.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
var NotificationKind;

(function(NotificationKind) {
NotificationKind["NEXT"] = "N";
NotificationKind["ERROR"] = "E";
NotificationKind["COMPLETE"] = "C";
})(NotificationKind || (NotificationKind = {}));
7 changes: 7 additions & 0 deletions integration/side-effects/snapshots/esm/websocket.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
var NotificationKind;

(function(NotificationKind) {
NotificationKind["NEXT"] = "N";
NotificationKind["ERROR"] = "E";
NotificationKind["COMPLETE"] = "C";
})(NotificationKind || (NotificationKind = {}));
8 changes: 8 additions & 0 deletions integration/side-effects/snapshots/esm5/index.js
Original file line number Diff line number Diff line change
@@ -1 +1,9 @@
import "tslib";

var NotificationKind;

(function(NotificationKind) {
NotificationKind["NEXT"] = "N";
NotificationKind["ERROR"] = "E";
NotificationKind["COMPLETE"] = "C";
})(NotificationKind || (NotificationKind = {}));
8 changes: 8 additions & 0 deletions integration/side-effects/snapshots/esm5/operators.js
Original file line number Diff line number Diff line change
@@ -1 +1,9 @@
import "tslib";

var NotificationKind;

(function(NotificationKind) {
NotificationKind["NEXT"] = "N";
NotificationKind["ERROR"] = "E";
NotificationKind["COMPLETE"] = "C";
})(NotificationKind || (NotificationKind = {}));
8 changes: 8 additions & 0 deletions integration/side-effects/snapshots/esm5/testing.js
Original file line number Diff line number Diff line change
@@ -1 +1,9 @@
import "tslib";

var NotificationKind;

(function(NotificationKind) {
NotificationKind["NEXT"] = "N";
NotificationKind["ERROR"] = "E";
NotificationKind["COMPLETE"] = "C";
})(NotificationKind || (NotificationKind = {}));
8 changes: 8 additions & 0 deletions integration/side-effects/snapshots/esm5/websocket.js
Original file line number Diff line number Diff line change
@@ -1 +1,9 @@
import "tslib";

var NotificationKind;

(function(NotificationKind) {
NotificationKind["NEXT"] = "N";
NotificationKind["ERROR"] = "E";
NotificationKind["COMPLETE"] = "C";
})(NotificationKind || (NotificationKind = {}));
2 changes: 1 addition & 1 deletion integration/systemjs/systemjs-compatibility-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ var System = require('systemjs');
var path = require('path');

System.config({
map: { 'rxjs': path.join(__dirname, '..', '..', 'dist', 'package', '/') },
map: { 'rxjs': path.join(__dirname, '..', '..', 'dist', 'cjs', '/') },
packages: {
'rxjs': {main: 'index.js', defaultExtension: 'js' },
'rxjs/ajax': {main: 'index.js', defaultExtension: 'js' },
Expand Down
Loading

0 comments on commit de6f1ef

Please sign in to comment.