Skip to content

Conversation

@matiboy
Copy link
Collaborator

@matiboy matiboy commented Jan 7, 2023

Minor docs amendments

Reviving the feature of switch_map proposed in #634 ; however I followed the RxJS implementation whereby:

  1. The projector receives the map's index (use map_index instead of map)
  2. There is no default projector. I don't feel that either identity or of is relevant, but would like to hear your thoughts on that since that was part of the conversation on Add switch_map operator and equivalent starred and indexed #634 @giff-h

Minor docs amendments
@matiboy matiboy requested a review from dbrattli January 7, 2023 06:23
@coveralls
Copy link

coveralls commented Jan 7, 2023

Coverage Status

Coverage: 93.433% (+0.04%) from 93.396% when pulling 2a7d721 on feat/switch_map into a10cc1c on master.

@dbrattli
Copy link
Collaborator

dbrattli commented Jan 7, 2023

  1. Should we call it switch_map_indexed? This would align with flap_map vs flat_map_indexed
  2. If you make the mapper optional, then you will automatically get the identity behaviour because of map_idexed where the mapper is optional.

@matiboy matiboy requested a review from dbrattli January 8, 2023 22:28
Copy link
Collaborator

@dbrattli dbrattli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thanks for adding!

@MainRo
Copy link
Collaborator

MainRo commented Feb 3, 2023

@dbrattli can we merge this PR?

@dbrattli dbrattli merged commit af1663d into master Mar 4, 2023
@dbrattli dbrattli deleted the feat/switch_map branch March 4, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants