Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write FullHttpResponse when possible #143

Closed
NiteshKant opened this issue Jun 16, 2014 · 1 comment
Closed

Write FullHttpResponse when possible #143

NiteshKant opened this issue Jun 16, 2014 · 1 comment
Milestone
0.3.6

Comments

@NiteshKant
Copy link
Member

HttpServerResponse always writes HTTP header and content separately as two channel writes.
This can be optimized by detecting if the response has zero or one write i.e. when the content-length header is set and is equal to zero OR the length of the content bytes written.
@NiteshKant NiteshKant added this to the 0.3.6 milestone Jun 16, 2014
@NiteshKant NiteshKant self-assigned this Jun 16, 2014
NiteshKant pushed a commit to NiteshKant/RxNetty that referenced this issue Jun 16, 2014
Fixes issue ReactiveX#143
92044ff 
Optimize by writing FullHttpResponse instead of headers, content and LastHttpContent when there is no content or a single content buffer.
NiteshKant added a commit that referenced this issue Jun 16, 2014
@NiteshKant
Merge pull request #144 from NiteshKant/master
2337be3 
Fixes issue #143
@NiteshKant
Copy link
Member Author

Fixed by PR #144

@NiteshKant NiteshKant removed their assignment Aug 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.6
Development

No branches or pull requests
1 participant
@NiteshKant