3.x: onReduceBackpressure internals cleanup #7151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
akarnokd
commented
Jan 17, 2021
akarnokd
commented
- Simplify empty/non-empty cases.
- Fix cancellation order and wrong fall-through.
- Add deterministic test to cover the reduction cases.
Codecov Report
@@ Coverage Diff @@
## 3.x #7151 +/- ##
============================================
- Coverage 99.55% 99.53% -0.03%
+ Complexity 6709 6707 -2
============================================
Files 745 745
Lines 47327 47327
Branches 6375 6375
============================================
- Hits 47117 47106 -11
- Misses 93 99 +6
- Partials 117 122 +5 Continue to review full report at Codecov.
|
ansip
reviewed
Jan 18, 2021
...a/io/reactivex/rxjava3/internal/operators/flowable/FlowableOnBackpressureReduceWithTest.java
Outdated
Show resolved
Hide resolved
ansip
reviewed
Jan 18, 2021
| @@ -90,6 +90,30 @@ public void simpleBackpressure() { | |||
| ts.assertNotComplete(); | |||
| } | |||
|
|
|||
| @Test | |||
| public void reduceBackpressuredSync() { | |||
There was a problem hiding this comment.
what is the difference from synchronousDrop test, maybe just rename it to reduceBacpressuredSync?
There was a problem hiding this comment.
Different request pattern.
vanniktech
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.