Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Remove Maybe.onExceptionResumeNext #6844

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

akarnokd
Copy link
Member

It was always very peculiar to let only checked exceptions resumed.

Resolves #6842

@akarnokd akarnokd added this to the 3.0 milestone Jan 14, 2020
@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #6844 into 3.x will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6844      +/-   ##
============================================
+ Coverage     98.24%   98.28%   +0.03%     
+ Complexity     6381     6376       -5     
============================================
  Files           715      715              
  Lines         46529    46522       -7     
  Branches       6388     6387       -1     
============================================
+ Hits          45714    45723       +9     
+ Misses          292      285       -7     
+ Partials        523      514       -9
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <100%> (ø) 178 <0> (-1) ⬇️
...va3/internal/operators/maybe/MaybeOnErrorNext.java 100% <100%> (ø) 2 <1> (ø) ⬇️
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...java3/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
...eactivex/rxjava3/processors/BehaviorProcessor.java 95.56% <0%> (-3.45%) 49% <0%> (-1%)
...nternal/operators/observable/ObservableWindow.java 98.18% <0%> (-1.82%) 3% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 94.18% <0%> (-1.17%) 2% <0%> (ø)
...operators/observable/ObservableMergeWithMaybe.java 99.09% <0%> (-0.91%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 89.68% <0%> (-0.8%) 2% <0%> (ø)
...ternal/operators/observable/ObservableGroupBy.java 95.08% <0%> (-0.55%) 2% <0%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ed5416...a09fa7b. Read the comment docs.

@akarnokd akarnokd merged commit 1cf5b9d into ReactiveX:3.x Jan 14, 2020
@akarnokd akarnokd deleted the RemoveOnExceptionResumeNext branch January 14, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.x: Remove the remaining onExceptionResumeNext operator(s)
1 participant