Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Improve JavaDocs of Maybe #6815

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Jan 7, 2020

Improve the javadocs by:

  • Adding {@code} and {@link} tags
  • Fixed wording and copy-paste mistakes
  • Added @throws for the parameter validation exceptions

@akarnokd akarnokd added this to the 3.0 milestone Jan 7, 2020
@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #6815 into 3.x will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6815      +/-   ##
============================================
+ Coverage     98.23%   98.26%   +0.03%     
- Complexity     6376     6377       +1     
============================================
  Files           715      715              
  Lines         46486    46486              
  Branches       6371     6371              
============================================
+ Hits          45666    45681      +15     
+ Misses          293      289       -4     
+ Partials        527      516      -11
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/io/reactivex/rxjava3/core/Single.java 100% <ø> (ø) 151 <0> (ø) ⬇️
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <ø> (ø) 179 <0> (ø) ⬇️
.../operators/observable/ObservableFlatMapSingle.java 91.26% <0%> (-1.59%) 2% <0%> (ø)
...ivex/rxjava3/subscribers/SerializedSubscriber.java 98.86% <0%> (-1.14%) 26% <0%> (-1%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 93.75% <0%> (-1.05%) 2% <0%> (ø)
...3/internal/operators/flowable/FlowablePublish.java 97.53% <0%> (-0.99%) 17% <0%> (ø)
...perators/observable/ObservableMergeWithSingle.java 99.05% <0%> (-0.95%) 2% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 92.25% <0%> (-0.71%) 2% <0%> (ø)
.../io/reactivex/rxjava3/subjects/UnicastSubject.java 98.64% <0%> (-0.68%) 61% <0%> (-1%)
...internal/operators/flowable/FlowableObserveOn.java 96.65% <0%> (-0.56%) 3% <0%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e2fa63...1028365. Read the comment docs.

@akarnokd akarnokd merged commit 84677c5 into ReactiveX:3.x Jan 8, 2020
@akarnokd akarnokd deleted the MaybeJavadocCleanup0107 branch January 8, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant