Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Remove now unnecessary unchecked warning suppressions #6790

Merged
merged 1 commit into from
Dec 22, 2019

Conversation

akarnokd
Copy link
Member

Most varargs places now have @SafeVarargs so there is no need for @SuppressWarnings("unchecked"). Some non-test classes need still updating though.

@akarnokd akarnokd added Test Cleanup 3.x Java 8 Issues and PRs related to Java 8 support labels Dec 22, 2019
@akarnokd akarnokd added this to the 3.0 milestone Dec 22, 2019
@codecov
Copy link

codecov bot commented Dec 22, 2019

Codecov Report

Merging #6790 into 3.x will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##               3.x    #6790      +/-   ##
===========================================
+ Coverage     98.2%   98.23%   +0.03%     
- Complexity    6283     6286       +3     
===========================================
  Files          696      696              
  Lines        45390    45390              
  Branches      6233     6233              
===========================================
+ Hits         44574    44590      +16     
+ Misses         288      280       -8     
+ Partials       528      520       -8
Impacted Files Coverage Δ Complexity Δ
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...eactivex/rxjava3/processors/BehaviorProcessor.java 96.58% <0%> (-1.47%) 51% <0%> (+1%)
...ternal/operators/completable/CompletableMerge.java 95.94% <0%> (-1.36%) 2% <0%> (ø)
...operators/observable/ObservableMergeWithMaybe.java 99.09% <0%> (-0.91%) 2% <0%> (ø)
...a3/internal/operators/flowable/FlowableReplay.java 91.97% <0%> (-0.83%) 19% <0%> (ø)
...al/operators/observable/ObservableWindowTimed.java 96.12% <0%> (-0.65%) 4% <0%> (ø)
...rnal/operators/observable/ObservableSwitchMap.java 91.57% <0%> (-0.53%) 3% <0%> (ø)
...va3/internal/operators/parallel/ParallelRunOn.java 96.61% <0%> (-0.49%) 8% <0%> (ø)
.../reactivex/rxjava3/processors/ReplayProcessor.java 97.34% <0%> (-0.41%) 52% <0%> (ø)
...a/io/reactivex/rxjava3/subjects/ReplaySubject.java 97.51% <0%> (+0.41%) 50% <0%> (ø) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bd2a01...6f4c2e7. Read the comment docs.

@akarnokd akarnokd merged commit 0b92c6f into ReactiveX:3.x Dec 22, 2019
@akarnokd akarnokd deleted the TestCleanup_1222a branch December 22, 2019 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Cleanup Java 8 Issues and PRs related to Java 8 support Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant