Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add abort signal to 'from' function and fix bug for 'merge' function #357

Closed
wants to merge 2 commits into from
Closed

add abort signal to 'from' function and fix bug for 'merge' function #357

wants to merge 2 commits into from

Conversation

eunohshure
Copy link

Description:

  1. from operator doesn't take signal for async iterable source.
  2. merge function can cause unhandled rejected promise condition

Related issue (if exists):

  1. from with abort signal #352
  2. merge function can cause unhandled rejected promise condition #353

@eunohshure
Update asynciterablex.ts
0ae880c
@eunohshure
Update merge.ts
80e2c0b 
don't create dangling promises in async merge before yielding
@trxcllnt
Copy link
Member

I have the merge fix in #354, but the change breaks the unit tests. It's not immediately obvious to me what the issue is.

@trxcllnt
Copy link
Member

I updated #354 with a different fix, and now the code in #353 runs without exiting due to an unhandled exception error.

@trxcllnt trxcllnt closed this Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eunohshure @trxcllnt