Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Quick and Nimble (Swift 4.2+ support) #156

Merged
merged 5 commits into from
Apr 1, 2019
Merged

Updated Quick and Nimble (Swift 4.2+ support) #156

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
721a32b
Updated Quick and Nimble
jakovi89 Apr 1, 2019
13a490c
Use XCode 10.2 on CI
jakovi89 Apr 1, 2019
97805c6
MacOS deployment target set to 10.10
jakovi89 Apr 1, 2019
0f9f3db
MacOS target set to 10.10 for Test only
jakovi89 Apr 1, 2019
327bdb7
MacOS Test set to 10.10 for all its targets
jakovi89 Apr 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ReactiveObjC.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1988,6 +1988,7 @@
developmentRegion = English;
hasScannedForEncodings = 0;
knownRegions = (
English,
en,
);
mainGroup = D04725E019E49ED7006002AA;
Expand Down Expand Up @@ -2823,7 +2824,7 @@
CURRENT_PROJECT_VERSION = 1;
ENABLE_TESTABILITY = YES;
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
MACOSX_DEPLOYMENT_TARGET = 10.9;
MACOSX_DEPLOYMENT_TARGET = 10.10;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the deployment target of the test target only? The actual framework should be able to stay deployable to 10.9.

PRODUCT_BUNDLE_IDENTIFIER = "org.reactivecocoa.$(PRODUCT_NAME:rfc1034identifier)";
PRODUCT_NAME = "$(PROJECT_NAME)";
TVOS_DEPLOYMENT_TARGET = 9.0;
Expand All @@ -2846,7 +2847,7 @@
CURRENT_PROJECT_VERSION = 1;
GCC_OPTIMIZATION_LEVEL = 0;
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
MACOSX_DEPLOYMENT_TARGET = 10.9;
MACOSX_DEPLOYMENT_TARGET = 10.10;
PRODUCT_BUNDLE_IDENTIFIER = "org.reactivecocoa.$(PRODUCT_NAME:rfc1034identifier)";
PRODUCT_NAME = "$(PROJECT_NAME)";
TVOS_DEPLOYMENT_TARGET = 9.0;
Expand Down Expand Up @@ -2996,7 +2997,7 @@
CODE_SIGNING_REQUIRED = NO;
CURRENT_PROJECT_VERSION = 1;
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
MACOSX_DEPLOYMENT_TARGET = 10.9;
MACOSX_DEPLOYMENT_TARGET = 10.10;
PRODUCT_BUNDLE_IDENTIFIER = "org.reactivecocoa.$(PRODUCT_NAME:rfc1034identifier)";
PRODUCT_NAME = "$(PROJECT_NAME)";
TVOS_DEPLOYMENT_TARGET = 9.0;
Expand Down Expand Up @@ -3078,7 +3079,7 @@
CODE_SIGNING_REQUIRED = NO;
CURRENT_PROJECT_VERSION = 1;
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
MACOSX_DEPLOYMENT_TARGET = 10.9;
MACOSX_DEPLOYMENT_TARGET = 10.10;
PRODUCT_BUNDLE_IDENTIFIER = "org.reactivecocoa.$(PRODUCT_NAME:rfc1034identifier)-Tests";
PRODUCT_NAME = "$(PROJECT_NAME)";
TVOS_DEPLOYMENT_TARGET = 9.0;
Expand Down