Generalize pointmasses for abstractarray #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvdmitri
reviewed
Aug 12, 2024
src/densities/pointmass.jl
Outdated
| function Base.precision(distribution::PointMass{V}) where {T<:Real,V<:AbstractVector{T}} | ||
| return one(T) ./ cov(distribution) | ||
| function BayesBase.cov(distribution::PointMass{M}) where {T<:Real,N,M<:AbstractArray{T,N}} | ||
| return error("cov(::PointMass{ <: AbstractMatrix }) is not defined") |
There was a problem hiding this comment.
The error mentions AbstractMatrix, but accepts arbitrary AbstractArray
bvdmitri
reviewed
Aug 12, 2024
src/densities/pointmass.jl
Outdated
| function BayesBase.probvec( | ||
| distribution::PointMass{M} | ||
| ) where {T<:Real,N,M<:AbstractArray{T,N}} | ||
| return error("probvec(::PointMass{ <: AbstractMatrix }) is not defined") |
bvdmitri
reviewed
Aug 12, 2024
|
Just as a side note, perhaps we should somehow rewrite PointMass to allow literally any object, but some may or may not support all operations, which can be determined by a trait-based system. This way we could close the #10 |
bvdmitri
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically what the PR title says. I'm not sure about
Base.ndimsfor vectors now. I implemented it separately now for backwards compatibility but it seems that it is only used instdandvarand can therefore also just work with the generic implementation.