Skip to content

Conversation

@hwpang
Copy link
Contributor

@hwpang hwpang commented Mar 2, 2023

This is a twin PR with ReactionMechanismGenerator/RMG-Py#2388.

Copy link
Collaborator

@mjohnson541 mjohnson541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few comments!

@hwpang hwpang force-pushed the deadend_radical branch 6 times, most recently from 101181e to 82a2ff6 Compare April 4, 2023 19:31
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #203 (b6c7b47) into main (78b0518) will increase coverage by 0.18%.
The diff coverage is 65.62%.

❗ Current head b6c7b47 differs from pull request most recent head df1224e. Consider uploading reports for the commit df1224e to get more accurate results

@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
+ Coverage   49.83%   50.02%   +0.18%     
==========================================
  Files          31       31              
  Lines        7900     7994      +94     
==========================================
+ Hits         3937     3999      +62     
- Misses       3963     3995      +32     
Impacted Files Coverage Δ
src/TestEdgeAnalysis.jl 100.00% <ø> (ø)
src/EdgeAnalysis.jl 48.59% <65.62%> (+2.64%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mjohnson541
mjohnson541 previously approved these changes Apr 12, 2023
@mjohnson541 mjohnson541 merged commit 63ddc79 into main May 16, 2023
@mjohnson541 mjohnson541 deleted the deadend_radical branch May 16, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants