Skip to content

Conversation

@kfir4444
Copy link
Collaborator

@kfir4444 kfir4444 commented May 2, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #650 (8413b6c) into main (6e1334e) will increase coverage by 0.00%.
The diff coverage is 20.00%.

@@           Coverage Diff           @@
##             main     #650   +/-   ##
=======================================
  Coverage   73.13%   73.13%           
=======================================
  Files          99       99           
  Lines       26283    26284    +1     
  Branches     5496     5497    +1     
=======================================
+ Hits        19221    19223    +2     
+ Misses       5700     5699    -1     
  Partials     1362     1362           
Impacted Files Coverage Δ
arc/parser.py 84.03% <20.00%> (-0.12%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kfir4444 kfir4444 requested a review from alongd May 2, 2023 17:22
Copy link
Member

@alongd alongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added minor comments

@kfir4444 kfir4444 force-pushed the Fixed_logic_issue branch 2 times, most recently from 6930ee9 to a73c476 Compare May 3, 2023 08:18
@alongd alongd changed the title Made sue that parse_xyz returns a dict xyz Make sure that parse_xyz returns a dict xyz May 3, 2023
@kfir4444 kfir4444 force-pushed the Fixed_logic_issue branch from a73c476 to 8413b6c Compare May 4, 2023 06:19
@kfir4444 kfir4444 merged commit a56b0df into main May 4, 2023
@kfir4444 kfir4444 deleted the Fixed_logic_issue branch May 4, 2023 08:06
Copy link
Contributor

@Lilachn91 Lilachn91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants